Skip to content

tidy: Robbins-Monore Delayed sanitzer#926

Merged
KSkwarczynski merged 3 commits into
developfrom
tidy/sanitizer
Jun 11, 2026
Merged

tidy: Robbins-Monore Delayed sanitzer#926
KSkwarczynski merged 3 commits into
developfrom
tidy/sanitizer

Conversation

@KSkwarczynski

Copy link
Copy Markdown
Member

Pull request description

Ali found that Delayed with RB doesn't work which Dr Wallace forgot.

Adding sanitizer after chat with both of them.

There is a solution for this but keep sanitizer until it's fixed


@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions Bot added the MCMC 🎲 MCMC related label Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

Hi, I am MaCh3-Telemetry bot

Memory and CPU Usage Summary

### Memory and CPU Usage Summary

| Metric  |     Mean    |      Max    |
|---------|-------------|-------------|
| **RAM** |   357.34 MB |   360.07 MB |
| **CPU** |    95.98 %  |    97.75 %  |

Memory Usage Plot

You can view the memory usage plot directly in the job summary from the link above.

@KSkwarczynski KSkwarczynski marked this pull request as draft June 5, 2026 13:36
@KSkwarczynski

Copy link
Copy Markdown
Member Author

Silly me, sanitizer has to be moved away from constructor...

@KSkwarczynski KSkwarczynski marked this pull request as ready for review June 6, 2026 20:02
Comment thread Fitters/DelayedMR2T2.cpp Outdated
Comment thread Fitters/DelayedMR2T2.cpp Outdated
Comment thread Fitters/DelayedMR2T2.cpp Outdated

@henry-wallace-phys henry-wallace-phys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks with code changes

@KSkwarczynski KSkwarczynski merged commit 4f97b7a into develop Jun 11, 2026
28 checks passed
@KSkwarczynski KSkwarczynski deleted the tidy/sanitizer branch June 11, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

MCMC 🎲 MCMC related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants